Add option to not colorize notification#4643
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Nov 1, 2020
Merged
Conversation
Stypox
requested changes
Oct 25, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Code looks good to me, thank you for taking care of this!
app/src/main/java/org/schabi/newpipe/player/NotificationUtil.java
Outdated
Show resolved
Hide resolved
Member
|
Please move the setting above the action buttons configuration, below scale thumbnail, and also hide it in case the user is on API <21. In order to hide multiple views at a time you can use a Group |
Collaborator
Author
|
I'll adjust the PR when #4652 gets merged |
XiangRongLin
force-pushed
the
colorize_notification
branch
2 times, most recently
from
4ecff0e to
47182d9
Compare
Collaborator
Author
|
@Stypox I rebased it onto my PR and added the API level check |
2 tasks
Stypox
force-pushed
the
colorize_notification
branch
from
47182d9 to
974f8f6
Compare
Stypox
reviewed
Nov 1, 2020
Stypox
approved these changes
Nov 1, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
updated after rebase
app-debug.zip
Due diligence